Skip to content

Issue #2796 View Column type enumeration work around #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2025
Merged

Issue #2796 View Column type enumeration work around #2798

merged 6 commits into from
Jan 24, 2025

Conversation

JohnGoldInc
Copy link
Contributor

@JohnGoldInc JohnGoldInc commented Jan 23, 2025 •
edited by ErikEJ
Loading

Using this work-around, the column type of columns can be established by using a User-Defined Table Type Named the same as the View, with columns named the same as the View's columns.

i.e.

CREATE VIEW [dbo].[AllTypes]
AS

SELECT 
 CAST( 0x1  AS bit 				  ) col_bit 						
,CAST( 0x2  AS tinyint			  ) col_tinyint			  
,CAST( 0x3  AS smallint			  ) col_smallint		  
,CAST( 0x4  AS int				  ) col_int				  
,CAST( 0x5  AS bigint			  ) col_bigint			  
,CAST( 6  AS decimal 			  ) col_decimal 		
,CAST( 7  AS numeric 			  ) col_numeric 		
,CAST( 8  AS money				  ) col_money			
,CAST( 9  AS smallmoney		  ) col_smallmoney		  
,CAST( 10 AS float				  ) col_float			  
,CAST( 11  AS real				  ) col_real			  
,CAST( '12/12/12'  AS date				  ) col_date			
,CAST( '13:13'  AS time				  ) col_time			
,CAST( '12/14/2014 14:14' AS datetime2		  ) col_datetime2		
,CAST( '12/15/2015 15:15'  AS datetimeoffset	  ) col_datetimeoffset	  
,CAST( '12/16/2016 16:16'  AS datetime			  ) col_datetime		
,CAST( '12/17/17'  AS smalldatetime		  ) col_smalldatetime
,CAST( 0x18  AS varchar(1)			  ) col_varchar			
,CAST( '19'  AS text				  ) col_text			
,CAST( 0x20  AS nchar				  ) col_nchar			
,CAST( 0x21 AS nvarchar(1)		  ) col_nvarchar		  
,CAST( '22'  AS ntext				  ) col_ntext			
,CAST( 0x23  AS binary			  ) col_binary			  
,CAST( 0x24 AS varbinary(1)			  ) col_varbinary
,CAST( 0x25 AS image				  ) col_image			
,CAST( 0x26  AS rowversion		  ) col_rowversion		  
,CAST( 0x27 AS uniqueidentifier	  ) col_uniqueidentifier  
,CAST( '<root>28</root>'  AS xml				  ) col_xml				  

GO 

CREATE TYPE [dbo].[AllTypes] AS TABLE (
	[col_bit] [bit] NULL,
	[col_tinyint] [tinyint] NULL,
	[col_smallint] [smallint] NULL,
	[col_int] [int] NULL,
	[col_bigint] [bigint] NULL,
	[col_decimal] [decimal](18, 0) NULL,
	[col_numeric] [numeric](18, 0) NULL,
	[col_money] [money] NULL,
	[col_smallmoney] [smallmoney] NULL,
	[col_float] [float] NULL,
	[col_real] [real] NULL,
	[col_date] [date] NULL,
	[col_time] [time](7) NULL,
	[col_datetime2] [datetime2](7) NULL,
	[col_datetimeoffset] [datetimeoffset](7) NULL,
	[col_datetime] [datetime] NULL,
	[col_smalldatetime] [smalldatetime] NULL,
	[col_varchar] [varchar](1) NULL,
	[col_text] [text] NULL,
	[col_nchar] [nchar](30) NULL,
	[col_nvarchar] [nvarchar](1) NULL,
	[col_ntext] [ntext] NULL,
	[col_binary] [binary](30) NULL,
	[col_varbinary] [varbinary](1) NULL,
	[col_image] [image] NULL,
	[col_rowversion] [timestamp] NULL,
	[col_uniqueidentifier] [uniqueidentifier] NULL,
	[col_xml] [xml] NULL
) 
GO

@JohnGoldInc
Issue ErikEJ#2796 View Column type enumeration work around using User…
2b99c0b 
…-Defined Table Type Named the same as View
@ErikEJ
Copy link
Owner

ErikEJ commented Jan 23, 2025

Interesting approach! Can you look at the build failure?

@JohnGoldInc
Fix for error:
4a9f75a 
Your project file doesn't list 'win-x64' as a "RuntimeIdentifier". You should add 'win-x64' to the "RuntimeIdentifiers" property in your project file and then re-run NuGet restore.
@JohnGoldInc
Copy link
Contributor Author

Interesting approach! Can you look at the build failure?

I don't think it was my stuff, as my fix was in a project I didn't touch... but the solution now builds locally; let's see what it does here.

@ErikEJ
Copy link
Owner

ErikEJ commented Jan 23, 2025

Looks like you added a project in the tests folder...

@JohnGoldInc
Copy link
Contributor Author

Looks like you added a project in the tests folder...

The dacpac builder project, I can remove it now that the dacpac is added?

@ErikEJ
Copy link
Owner

ErikEJ commented Jan 23, 2025

Yes, maybe preserve the .sql script as test content?

@JohnGoldInc
Copy link
Contributor Author

Yes, maybe preserve the .sql script as test content?

Completed

@ErikEJ
Copy link
Owner

ErikEJ commented Jan 23, 2025

What will happen if a users .dacpac contains a table type and a view with same name (could happen) ?

@JohnGoldInc
Your project file doesn't list 'win' as a "RuntimeIdentifier". You s…
ea65793 
…hould add 'win' to the "RuntimeIdentifiers" property in your project file and then re-run NuGet restore.
@JohnGoldInc
Copy link
Contributor Author

What will happen if a users .dacpac contains a table type and a view with same name (could happen) ?

It only tries the Table type method if it would otherwise be skipped previously, and the table type name and column names have to both match the view name and column name; that is how it works

@JohnGoldInc
Copy link
Contributor Author

I figure if they are all named the same, it's pretty guaranteed that they should be the same type.

I Could add an extra check to ensure all Table Type columns exist in the view?

@ErikEJ
Copy link
Owner

ErikEJ commented Jan 23, 2025

That would be great thanks

@ErikEJ
Copy link
Owner

ErikEJ commented Jan 23, 2025

Thanks, this is a great contribution - I will have a closer look tomorrow

@ErikEJ ErikEJ merged commit 37b4d5d into ErikEJ:master Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikEJ ErikEJ ErikEJ left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnGoldInc @ErikEJ